Add eslint checks #97218
Merged
Add eslint checks #97218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #97211) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
eslint-checks
branch
from
719e47f to
116c5a2
Compare
|
@bors r+ rollup=always |
|
📌 Commit 116c5a2 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 21, 2022
…riddle
Add eslint checks
The first check is to ensure that `=>` is always surrounded with whitespaces.
The second is to ensure that the dict objects looks like this: `{"a": 2}` and not `{"a" : 2}` or `{"a":2}`.
r? `@notriddle`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2022
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#97190 (Add implicit call to from_str via parse in documentation) - rust-lang#97218 (Add eslint checks) - rust-lang#97219 (make ptr::invalid not the same as a regular int2ptr cast) - rust-lang#97223 (Remove quadratic behaviour from -Zunpretty=hir-tree.) - rust-lang#97232 (typo) - rust-lang#97237 (Add some more weird-exprs) - rust-lang#97238 (Bump LLVM fetched from CI to fix run-make) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first check is to ensure that
=>is always surrounded with whitespaces.The second is to ensure that the dict objects looks like this:
{"a": 2}and not{"a" : 2}or{"a":2}.r? @notriddle